fix: Convert MemoryLimitMB to int before comparison in SingularityComputingElement #8424
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldbr
previously approved these changes
Jan 13, 2026
fstagni
previously approved these changes
Jan 13, 2026
fstagni
force-pushed
the
fix/singularity-memory-limit-type
branch
from
bfdb9dc to
981de8f
Compare
…putingElement The MemoryLimitMB parameter from configuration is a string, causing a TypeError when compared with the integer maxRAM in min().
chrisburr
force-pushed
the
fix/singularity-memory-limit-type
branch
from
981de8f to
7814c0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
*Resources
FIX: SingularityComputingElement: convert MemoryLimitMB to int before comparison with maxRAM
ENDRELEASENOTES
The
MemoryLimitMBparameter from configuration is a string, causing aTypeErrorwhen compared with the integermaxRAMinmin():